[build] Remove statically linked JNI artifacts #7553
+13
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component: ntcore
|
The gains are marginal because how we do the building, these projects basically cost just a linking step. iirc they don't even compile anything, or if they do its 1 or 2 files. Otherwise, I generally think I'm ok with this. You're right they're broken. They've also been broken for years anyway. |
Gold856
force-pushed
the
remove-static-jni-artifacts
branch
from
71884f8 to
853459f
Compare
Gold856
force-pushed
the
remove-static-jni-artifacts
branch
from
853459f to
20cbee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The loading framework for the
-jniartifacts was removed in #6600, so these just don't work anymore. We can remove them to reduce the amount of space used when building and save some time as well (although the gains seem to be marginal).Reference for CI build times and space savings: https://github.com/Gold856/allwpilib/actions/runs/12348391056